#167730641 Notifying New Travel Request #20

ChidiChuks · 2019-09-03T03:14:14Z

What does this PR do?

Have a notification created on Barefoot Nomad upon a user making a new travel request

Description of Task to be completed?

There will be two forms of notification to be implemented which are;

The push notification
The email notification
Create a notifications table
Install dependencies socket.io and auto-bind
Prepare the server
Set-up the project
Display New travel Requests
Add Notifications
Send Push and Email Notifications

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

#167730641

Screenshots (if appropriate)

Questions:

chuksjoe · 2019-09-03T16:41:17Z

What is the issue you having here bro @ChidiChuks ?

hound · 2019-09-04T03:11:13Z

src/database/seeders/20190904024301-notifications.js

+        ], {});
+    },
+
+    down: (queryInterface, Sequelize) => {


'Sequelize' is defined but never used no-unused-vars

hound · 2019-09-04T03:11:13Z

src/database/seeders/20190904024301-notifications.js

@@ -0,0 +1,23 @@
+module.exports = {
+    up: (queryInterface, Sequelize) => {


'Sequelize' is defined but never used no-unused-vars

hound · 2019-09-04T03:11:14Z

src/database/seeders/20190904024301-notifications.js

@@ -0,0 +1,23 @@
+module.exports = {


'module' is not defined no-undef

hound · 2019-09-04T03:11:14Z

src/database/models/notifications.js

@@ -0,0 +1,13 @@
+module.exports = (sequelize, DataTypes) => {


'module' is not defined no-undef

hound · 2019-09-04T03:11:14Z

src/database/migrations/20190904023213-create-notifications.js

+            }
+        });
+    },
+    down: (queryInterface, Sequelize) => {


'Sequelize' is defined but never used no-unused-vars

hound · 2019-09-04T03:11:14Z

src/database/migrations/20190904023213-create-notifications.js

@@ -0,0 +1,29 @@
+module.exports = {


'module' is not defined no-undef

ChidiChuks · 2019-09-04T04:29:30Z

What is the issue you having here bro @ChidiChuks ?

Thanks alot for this. I'm really trying to decide on which service worker would work properly on the app for the in-app notification. I'm contemplating between socket.io and web-push. But I think after my research and all I finally understood socket.io more and its' advantage

hound · 2019-09-04T21:49:05Z

src/routes/api/notifyRoutes.js

@@ -0,0 +1,5 @@
+import { Router } from 'express';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-09-04T21:49:06Z

src/database/models/departments.js

+        manager_email: DataTypes.TEXT
+    }, {});
+
+    departments.associate = (models) => {


'models' is defined but never used no-unused-vars

hound · 2019-09-04T21:49:06Z

src/database/models/departments.js

@@ -0,0 +1,17 @@
+module.exports = (sequelize, DataTypes) => {


'module' is not defined no-undef

hound · 2019-09-05T15:48:07Z

src/tests/mocks/users.js

@@ -0,0 +1,18 @@
+export default {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-09-05T15:48:07Z

src/services/notifyServices.js

@@ -0,0 +1,48 @@
+import Model from '../database/models';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-09-08T16:32:19Z

src/services/websocket.js

@@ -0,0 +1,13 @@
+import { io } from '../index';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-09-08T16:32:19Z

src/controllers/profile.js

+     * @returns {Object} the new user
+     * @description register a new client
+     */
+    static async getProfile(req, res) {


Parsing error: Unexpected token getProfile

hound · 2019-09-08T16:32:20Z

src/controllers/notifyControllers.js

+/* eslint-disable import/named */
+/* eslint-disable require-jsdoc */
+
+import models from '../models';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

@ChidiChuks Nice work

please what does this do?

we cannot but include html?

hound · 2019-09-09T10:11:18Z

src/tests/authTest.js

+        it('should return an error if the token is invalid', (done) => {
+            chai.request(app)
+                .post(`${prefix}/auth/logout`)
+                .set("Authorization", "Bearer hjgvju")


Strings must use singlequote quotes

hound · 2019-09-09T10:11:18Z

src/tests/authTest.js

+                    token = data.token;
+                    done();
+                });
+        })


Missing semicolon semi

hound · 2019-09-09T10:11:18Z

src/tests/authTest.js

+                .send(testuser)
+                .end((err, res) => {
+                    const { data } = res.body;
+                    token = data.token;


Use object destructuring prefer-destructuring

hound · 2019-09-09T10:11:18Z

src/tests/authTest.js

+                });
+        });
+
+        it('should contain a token value in its response data object', (done) => {


Block must not be padded by blank lines padded-blocks

hound · 2019-09-09T10:11:18Z

src/tests/authTest.js

+                });
+        });
+
+        it('should authenticate a user with a valid email and password', (done) => {


Block must not be padded by blank lines padded-blocks

hound · 2019-09-09T10:11:19Z

src/services/websocket.js

@@ -0,0 +1,5 @@
+import { io } from '..';
+
+export const eventEmitter = (eventName, data) => {


Prefer default export import/prefer-default-export

hound · 2019-09-09T10:11:19Z

src/routes/api/index.js

+const foo = (io = null) => {
+    router.use('/auth', auth);
+    router.get('/profile/:user_id', getProfile);
+    router.use('/request', checkToken, requestRouter(io));


'checkToken' is not defined no-undef
'requestRouter' is not defined no-undef

hound · 2019-09-09T10:11:19Z

src/routes/api/index.js

+
+const { getProfile } = profileController;
+
+const router = express.Router();


'express' is not defined no-undef

hound · 2019-09-09T10:11:20Z

src/middlewares/tokenMiddleware.js

        });
    }
-};
+};


Newline required at end of file but not found eol-last

hound · 2019-09-09T10:11:20Z

src/database/seeders/20190904024301-notifications.js

+    down: (queryInterface, Sequelize) => {
+        return queryInterface.bulkDelete('notifications', null, {});
+    }
+};


Newline required at end of file but not found eol-last

hound · 2019-09-09T14:19:10Z

src/controllers/travelControllers.js

-            
-            const travelObj = { user_id:userId, origin, destination, departure_date, travel_purpose };
+
+            const travelObj = { user_id: userId, origin, destination, departure_date, travel_purpose };


Expected a line break after this opening brace object-curly-newline
Expected a line break before this closing brace object-curly-newline
Line 17 exceeds the maximum line length of 100 max-len

hound · 2019-09-09T14:19:10Z

src/controllers/travelControllers.js

@@ -1,3 +1,5 @@
+import autoBind from 'auto-bind';
+import notifyServices from '../services/websocket'


'notifyServices' is defined but never used no-unused-vars
Missing semicolon semi

hound · 2019-09-09T14:19:10Z

src/controllers/travelControllers.js

@@ -1,3 +1,5 @@
+import autoBind from 'auto-bind';


'autoBind' is defined but never used no-unused-vars

hound · 2019-09-09T14:19:11Z

src/controllers/resetPassword.js

    sendPasswordResetEmail,
    receiveNewPassword
-  }
-
+}


Missing semicolon semi

hound · 2019-09-09T14:19:11Z

src/controllers/resetPassword.js

    })

    .catch(() => {
-      res.status(404).json("Invalid user")
+        res.status(404).json("Invalid user")


Missing semicolon semi
Strings must use singlequote quotes

hound · 2019-09-09T14:19:12Z

src/controllers/resetPassword.js

+        const payload = jwt.decode(token, secret)
+        if (payload.userId === user.id) {
+            bcrypt.genSalt(10, function(err, salt) {
+                if (err) return


Missing semicolon semi

hound · 2019-09-09T14:19:12Z

src/controllers/resetPassword.js

+        const secret = user.password + "-" + user.createdAt
+        const payload = jwt.decode(token, secret)
+        if (payload.userId === user.id) {
+            bcrypt.genSalt(10, function(err, salt) {


Missing space before function parentheses space-before-function-paren
Unexpected function expression prefer-arrow-callback
Unexpected unnamed function func-names

hound · 2019-09-09T14:19:12Z

src/controllers/resetPassword.js

-        })
-      }
+        const secret = user.password + "-" + user.createdAt
+        const payload = jwt.decode(token, secret)


Missing semicolon semi

hound · 2019-09-09T14:19:12Z

src/controllers/resetPassword.js

-          })
-        })
-      }
+        const secret = user.password + "-" + user.createdAt


Missing semicolon semi
Strings must use singlequote quotes
Unexpected string concatenation prefer-template

hound · 2019-09-09T14:19:13Z

src/controllers/resetPassword.js

-  const { password } = req.body
+const receiveNewPassword = (req, res) => {
+    const { userId, token } = req.params
+    const { password } = req.body


Missing semicolon semi

hound · 2019-09-09T14:19:15Z

src/database/seeders/20190824033354-departments.js

+                updatedAt: new Date(),
+            },
+        ], {}
+    ),


Unexpected newline before ')' function-paren-newline

hound · 2019-09-09T14:19:15Z

src/database/seeders/20190824033354-departments.js

@@ -0,0 +1,23 @@
+module.exports = {
+    up: (queryInterface) => queryInterface.bulkInsert(


Unexpected newline after '(' function-paren-newline

hound · 2019-09-09T14:19:15Z

src/routes/api/index.js

+    app.use(prefix, travel);
+    app.use(prefix, comment);
+    app.use(prefix, notify);
+};


Newline required at end of file but not found eol-last

hound · 2019-09-09T14:19:15Z

src/database/models/departments.js

+    };
+
+    return departments;
+};


Newline required at end of file but not found eol-last

hound · 2019-09-09T14:19:16Z

src/database/models/departments.js

+        manager_email: DataTypes.TEXT
+    }, {});
+
+    departments.associate = (models) => {


'models' is defined but never used no-unused-vars

hound · 2019-09-09T14:19:17Z

src/controllers/resetPassword.js

-  const { userId, token } = req.params
-  const { password } = req.body
+const receiveNewPassword = (req, res) => {
+    const { userId, token } = req.params


Missing semicolon semi

hound · 2019-09-09T14:19:17Z

src/controllers/resetPassword.js

+    const token = usePasswordHashToMakeToken(user)
+    const url = getPasswordResetURL(user, token)
+    const emailTemplate = resetPasswordTemplate(user, url)
+    transporter(emailTemplate, res)


Missing semicolon semi

hound · 2019-09-09T14:19:17Z

src/controllers/resetPassword.js

+    }
+    const token = usePasswordHashToMakeToken(user)
+    const url = getPasswordResetURL(user, token)
+    const emailTemplate = resetPasswordTemplate(user, url)


Missing semicolon semi

hound · 2019-09-09T14:19:17Z

src/controllers/resetPassword.js

+        res.status(404).json("No user with that email")
+    }
+    const token = usePasswordHashToMakeToken(user)
+    const url = getPasswordResetURL(user, token)


Missing semicolon semi

hound · 2019-09-09T14:19:17Z

src/controllers/resetPassword.js

+    } catch (err) {
+        res.status(404).json("No user with that email")
+    }
+    const token = usePasswordHashToMakeToken(user)


Missing semicolon semi

hound · 2019-09-09T14:19:19Z

src/utils/messageUtils.js

+    ],
+    welcome: 'Welcome to Archangel Barefoot Nomad Web App API.',
+    signupSuccess: (email) => `You have successfully registered with this email, ${email}.`,
+    verificationMessage: (hostUrl) => Click on this link to verify your email $ { url },


Parsing error: Unexpected token, expected ","

hound · 2019-09-09T14:19:19Z

src/routes/api/notifyRoutes.js

+module.exports = foo;
+
+
+export default router;


Newline required at end of file but not found eol-last

hound · 2019-09-09T14:19:19Z

src/routes/api/notifyRoutes.js

+const foo = (io = null) => {
+    router.use('/auth', auth);
+    router.get('/profile/:user_id', getProfile);
+    router.use('/request', getToken, verifyToken, requestRouter(io));


'requestRouter' is not defined no-undef

hound · 2019-09-09T14:19:20Z

src/routes/api/notifyRoutes.js

+
+
+const foo = (io = null) => {
+    router.use('/auth', auth);


'auth' is not defined no-undef

hound · 2019-09-09T14:19:20Z

src/controllers/resetPassword.js

+    try {
+        user = await queryByEmail(email)
+    } catch (err) {
+        res.status(404).json("No user with that email")


Missing semicolon semi
Strings must use singlequote quotes

hound · 2019-09-09T14:19:21Z

src/controllers/index.js

Unexpected line break before this closing brace object-curly-newline

hound · 2019-09-09T14:19:21Z

src/controllers/authControllers.js

+            errorResponse(res, statusCode.serverError, err.message);
+        }
+    },
+};


Newline required at end of file but not found eol-last

hound · 2019-09-09T14:19:21Z

src/controllers/authControllers.js

-     }
-   },
-};
+    logout: async(req, res) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-09T14:19:21Z

src/controllers/authControllers.js

+            } else {
+                const token = generateToken(data.id, email, data.role, data.first_name);
+                return successResponseWithData(res, statusCode.success, message.loginSuccess, {...data, token });
+            };


Unnecessary semicolon no-extra-semi
Unreachable code no-unreachable

hound · 2019-09-09T14:19:22Z

src/controllers/authControllers.js

+                throw new ApiErrors(message.incorrectPassword, statusCode.badRequest);
+            } else {
+                const token = generateToken(data.id, email, data.role, data.first_name);
+                return successResponseWithData(res, statusCode.success, message.loginSuccess, {...data, token });


A space is required after '{' object-curly-spacing
Line 78 exceeds the maximum line length of 100 max-len

hound · 2019-09-10T10:31:08Z

src/utils/email.js

-  };
-export default sendVerificationEmail;
+};
+export default sendVerificationEmail;


Newline required at end of file but not found eol-last

hound · 2019-09-10T10:31:08Z

src/tests/mocks/users.js

+    password: 'every125',
+    dept_id: 15327458,
+    role: 'line_manager'
+};


Newline required at end of file but not found eol-last

hound · 2019-09-10T10:31:09Z

src/services/travelServices.js

+            throw err;
+        }
+    },
+};


Newline required at end of file but not found eol-last

hound · 2019-09-10T10:31:09Z

src/services/travelServices.js

+            throw err;
+        }
+    },
+    findTravelById: async(id) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-10T10:31:09Z

src/services/travelServices.js

-		}
-	},
-};
+    oneWayTripService: async(travelObj) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-10T10:31:11Z

src/services/emailServices.js

-    try{
-     return await users.update(hash, { where: { id } });
-    }catch(err){
+const updatePassword = async(hash, id) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-10T10:31:11Z

src/services/emailServices.js

+    try {
+        return await users.findOne({ where: { id } });
+    } catch (err) {
+        throw err


Missing semicolon semi

hound · 2019-09-10T10:31:11Z

src/services/emailServices.js

+     * @param {String} id - user's id
+     * @returns {Promise} - sequelize response
+     */
+const queryById = async(id) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-10T10:31:11Z

src/services/emailServices.js

+        } catch (err) {
+            throw err;
+        }
+    }


Missing semicolon semi

hound · 2019-09-10T10:31:11Z

src/services/emailServices.js

-}catch(err){
-    throw err
-}   
+const queryByEmail = async(email) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-10T18:14:03Z

src/utils/statusCode.js

    notFound: 404,
    unauthorized: 401,
    serverError: 500
-};
+};


Newline required at end of file but not found eol-last

hound · 2019-09-10T18:14:03Z

src/utils/notifyEmailUtils.js

+        first_name,
+        last_name
+    } = userDetails;
+    const { destination, departure_date, return_date } => {


Parsing error: Unexpected token

hound · 2019-09-10T18:14:04Z

src/utils/messageUtils.js

+    invalidTravelId: 'The travel ID must be an integer value.',
+    nonExistentTravel: 'The travel request does not exist.',
+    emptyComment: 'comment cannot be empty.',
+};


Newline required at end of file but not found eol-last

hound · 2019-09-10T18:14:04Z

src/services/deptServices.js

+    } catch (err) {
+        throw err
+    }
+}


Missing semicolon semi
Newline required at end of file but not found eol-last

hound · 2019-09-10T18:14:04Z

src/services/deptServices.js

+    try {
+        return await users.update(hash, { where: { id } });
+    } catch (err) {
+        throw err


Missing semicolon semi

hound · 2019-09-10T18:14:06Z

src/services/deptServices.js

+        } catch (err) {
+            throw err;
+        }
+    }


Missing semicolon semi

hound · 2019-09-10T18:14:06Z

src/services/deptServices.js

+ * @param {String} email - line-manager's email
+ * @returns {Promise} - sequelize response
+ */
+export const findManagerByEmail = async(email) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-10T18:14:06Z

src/services/authServices.js

        try {
            return await blacklists.create({ expired_tokens: token })
        } catch (err) {
            throw err;
        }
    }

-};
+};


Newline required at end of file but not found eol-last

hound · 2019-09-10T18:14:06Z

src/services/authServices.js

    comparePassword: (password, hashedPassword) => compareSync(password, hashedPassword),

-    logoutService: async (token) => {
+    logoutService: async(token) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-10T18:14:06Z

src/services/authServices.js

-		} catch (err) {
-			throw err;
-		}
+    updateUserById: async(hash, id) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-11T15:03:52Z

src/database/seeders/20190904024301-notifications.js

+        },
+    ], {}),
+
+    down: (queryInterface, Sequelize) => queryInterface.bulkDelete('notifications', null, {})


'Sequelize' is defined but never used no-unused-vars

hound · 2019-09-11T15:03:52Z

src/services/authServices.js

-		} catch (err) {
-			throw err;
-		}
+    findUserById: async(id) => {


Duplicate key 'findUserById' no-dupe-keys
Missing space before function parentheses space-before-function-paren

hound · 2019-09-11T15:03:52Z

src/services/authServices.js

@@ -8,13 +8,13 @@ import sendVerificationEmail from '../utils/email';
 const { users, blacklists } = models;

 export default {
-    signupService: async (userObj) => {
+    signupService: async(userObj) => {


Missing space before function parentheses space-before-function-paren

hound · 2019-09-11T15:03:52Z

src/routes/api/travelRoute.js

@@ -12,4 +12,4 @@ const { getToken, verifyToken } = authUtils;
 // handles the api home route...
 route.post('/onewaytrip', getToken, verifyToken, validateTravelRequest, validateResult, createOneWayTrip);

-export default route;
+export default route;


Newline required at end of file but not found eol-last

hound · 2019-09-11T15:03:52Z

src/routes/api/authRoutes.js

+    passport.authenticate('google', {
+        failureRedirect: '/auth/signup',
+        successRedirect: '/requests',
+    }));


Expected a newline before ')' function-paren-newline

hound · 2019-09-11T15:03:54Z

src/database/migrations/20190823135448-create-users.js

+            type: Sequelize.DATE,
+        }
+    }),
+    down: (queryInterface, Sequelize) => queryInterface.dropTable('users')


'Sequelize' is defined but never used no-unused-vars

hound · 2019-09-11T15:03:54Z

src/database/migrations/20190823125926-create-departments.js

+            type: Sequelize.DATE
+        }
+    }),
+    down: (queryInterface, Sequelize) => queryInterface.dropTable('departments')


'Sequelize' is defined but never used no-unused-vars

hound · 2019-09-11T15:03:54Z

src/controllers/travelControllers.js

+            const data = await oneWayTripService(travelObj);
+
+            const emailVerify = await sendVerificationEmail(email,
+                'Travel Confirmation', message.notifyUser);


Expected a newline before ')' function-paren-newline

hound · 2019-09-11T15:03:54Z

src/controllers/travelControllers.js

+
+            const data = await oneWayTripService(travelObj);
+
+            const emailVerify = await sendVerificationEmail(email,


'emailVerify' is assigned a value but never used no-unused-vars
Expected a newline after '(' function-paren-newline

hound · 2019-09-11T15:03:54Z

src/controllers/notifyControllers.js

+    }
+};
+
+export const readAllNotification = async(req, res) => {


Missing space before function parentheses space-before-function-paren

- Create a table - Install dependencies and [Start #167730641]

hound · 2019-09-13T17:45:04Z

src/services/travelServices.js

    });
  } catch (error) {
    throw error;
  }
 };
+
+export const approveTravel = async (id) => {


Parsing error: approveTravel has already been exported. Exported identifiers must be unique.

- The push notification - The email notification Create a notifications table Install dependencies socket.io and auto-bind Prepare the server Set-up the project Display New travel Requests Add Notifications Send Push and Email Notifications [Finishes: #167730641]

hound · 2019-09-13T19:54:38Z

src/tests/travel.test.js

+                done();
+            });
+    });
+    before((done) => {


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T19:54:38Z

src/tests/travel.test.js

+                managerToken1 = data.token;
+                done();
+            });
+    });


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T19:54:38Z

src/tests/travel.test.js

+                const { data } = res.body;
+                managerToken1 = data.token;
+                done();
+            });


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T19:54:38Z

src/tests/travel.test.js

+            .end((err, res) => {
+                const { data } = res.body;
+                managerToken1 = data.token;
+                done();


Expected indentation of 8 spaces but found 16 indent

hound · 2019-09-13T19:54:38Z

src/tests/travel.test.js

+            .send(testManager1)
+            .end((err, res) => {
+                const { data } = res.body;
+                managerToken1 = data.token;


Expected indentation of 8 spaces but found 16 indent

hound · 2019-09-13T19:54:39Z

src/tests/travel.test.js

-        done();
-      });
-  });
+    before((done) => {


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T19:54:39Z

src/tests/travel.test.js

 });

 describe('Testing the travel approval route', () => {
-  let managerToken1, managerToken2;
+    let managerToken1, managerToken2;


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T19:54:39Z

src/tests/travel.test.js

+                expect(res).to.have.status(401);
+                done();
+            });
+    });


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T19:54:39Z

src/tests/travel.test.js

+            .end((err, res) => {
+                expect(res).to.have.status(401);
+                done();
+            });


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T19:54:40Z

src/tests/travel.test.js

+            .set('Authorization', adminToken)
+            .end((err, res) => {
+                expect(res).to.have.status(401);
+                done();


Expected indentation of 8 spaces but found 16 indent

chuksjoe

Well done bro @ChidiChuks. But I don't know how your implementation sends out the notification when a requester makes a travel request.
The Notification is meant to be sent when the request is created, but you didn't add any logic that sends it in the controller function that creates the request.

ChidiChuks · 2019-09-13T21:56:23Z

Well done bro @ChidiChuks. But I don't know how your implementation sends out the notification when a requester makes a travel request.
The Notification is meant to be sent when the request is created, but you didn't add any logic that sends it in the controller function that creates the request.

Oh. bro @chuksjoe that should have been missed out while I was resolving the conflicts. But in the meantime thanks for your observation. It has been included and a screenshot of it is above

- The push notification - The email notification - Create a notifications table - Install dependencies socket.io and auto-bind - Prepare the server - Set-up the project - Display New travel Requests - Add Notifications - Send Push and Email Notifications [Finishes: #167730641]

hound · 2019-09-13T22:21:31Z

src/routes/travelRoute.js

+    verifyToken,
+    verifyRole('manager'),
+    verifyDeptManagerAndRequestStatus,
+    approveTravelRequest,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T22:21:31Z

src/routes/travelRoute.js

+    getToken,
+    verifyToken,
+    verifyRole('manager'),
+    verifyDeptManagerAndRequestStatus,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T22:21:31Z

src/routes/travelRoute.js

+    '/travel/approve_request/:travel_id',
+    getToken,
+    verifyToken,
+    verifyRole('manager'),


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T22:21:31Z

src/routes/travelRoute.js

-  approveTravelRequest,
+    '/travel/approve_request/:travel_id',
+    getToken,
+    verifyToken,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T22:21:31Z

src/routes/travelRoute.js

-  verifyDeptManagerAndRequestStatus,
-  approveTravelRequest,
+    '/travel/approve_request/:travel_id',
+    getToken,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T22:21:32Z

src/routes/travelRoute.js

-  pendingManagerApproval,
-  getUserTravelStatus,
-  approveTravelRequest,
+    createOneWayTrip,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T22:21:32Z

src/tests/travel.test.js

+            .request(app)
+            .post(onewayRoute)
+            .set('Authorization', token)
+            .send(mutatedtravelRequest)


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T22:21:32Z

src/tests/travel.test.js

+        chai
+            .request(app)
+            .post(onewayRoute)
+            .set('Authorization', token)


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T22:21:33Z

src/tests/travel.test.js

-  });
+        chai
+            .request(app)
+            .post(onewayRoute)


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T22:21:33Z

src/tests/travel.test.js

-      });
-  });
+        chai
+            .request(app)


Expected indentation of 6 spaces but found 12 indent

danoseun

I can't see the logic that sends out the notification. Maybe you omitted it @ChidiChuks

- The push notification - The email notification - Create a notifications table - Install dependencies socket.io and auto-bind - Prepare the server - Set-up the project - Display New travel Requests - Add Notifications - Send Push and Email Notifications [Finishes: #167730641]

hound · 2019-09-13T22:39:57Z

src/tests/travel.test.js

+                expect(res).to.have.status(401);
+                done();
+            });
+    });


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-13T22:39:57Z

src/tests/travel.test.js

+            .end((err, res) => {
+                expect(res).to.have.status(401);
+                done();
+            });


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T22:39:58Z

src/tests/travel.test.js

+            .set('Authorization', token)
+            .end((err, res) => {
+                expect(res).to.have.status(401);
+                done();


Expected indentation of 8 spaces but found 16 indent

hound · 2019-09-13T22:39:58Z

src/tests/travel.test.js

+            .patch(approveRequestRoute)
+            .set('Authorization', token)
+            .end((err, res) => {
+                expect(res).to.have.status(401);


Expected indentation of 8 spaces but found 16 indent

hound · 2019-09-13T22:39:58Z

src/tests/travel.test.js

+            .request(app)
+            .patch(approveRequestRoute)
+            .set('Authorization', token)
+            .end((err, res) => {


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T22:39:59Z

src/tests/travel.test.js

+            .end((err, res) => {
+                expect(res).to.have.status(401);
+                done();
+            });


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T22:39:59Z

src/tests/travel.test.js

+            .set('Authorization', managerToken1)
+            .end((err, res) => {
+                expect(res).to.have.status(401);
+                done();


Expected indentation of 8 spaces but found 16 indent

hound · 2019-09-13T22:40:00Z

src/tests/travel.test.js

+            .patch(approveRequestRoute)
+            .set('Authorization', managerToken1)
+            .end((err, res) => {
+                expect(res).to.have.status(401);


Expected indentation of 8 spaces but found 16 indent

hound · 2019-09-13T22:40:00Z

src/tests/travel.test.js

+            .request(app)
+            .patch(approveRequestRoute)
+            .set('Authorization', managerToken1)
+            .end((err, res) => {


Expected indentation of 6 spaces but found 12 indent

hound · 2019-09-13T22:40:00Z

src/tests/travel.test.js

+        chai
+            .request(app)
+            .patch(approveRequestRoute)
+            .set('Authorization', managerToken1)


Expected indentation of 6 spaces but found 12 indent

chuksjoe

Well done brother @ChidiChuks.
Please attend to the inline comments I dropped and to the Hound-CI violation flags.

chuksjoe · 2019-09-14T06:39:25Z

src/controllers/travelControllers.js

+
+        const emailVerify = await sendVerificationEmail(email,
+            'Travel Confirmation', message.notifyUser);
+        emission('here', 'we made it');


Please, what message are you emitting here?

Please, what message are you emitting here?

That was me testing the feature however it haas been updated

chuksjoe · 2019-09-14T06:43:16Z

src/routes/travelRoute.js

@@ -1,28 +1,21 @@
 import { Router } from 'express';


You did not add a line of code in this file. Please, revert the changes.

@ChidiChuks please tidy up the commented lines

chuksjoe · 2019-09-14T06:45:34Z

src/services/travelServices.js

@@ -6,85 +6,64 @@ import models from '../models';



You did not add a line of code in this file. Please, revert changes.

chuksjoe · 2019-09-14T06:47:13Z

src/tests/travel.test.js

@@ -5,11 +5,11 @@ import dotenv from 'dotenv';



You did not add a line of code on this file. Please, revert changes.

chuksjoe · 2019-09-14T06:52:23Z

src/controllers/notifyControllers.js

+    try {
+      const user_id = req.users.id;
+      const allRequests = await notifications.findAll({ where: { receiver: user_id } });
+      return res.status(200).json({ status: 200, data: allRequests });


Thought we have a function that handles responses (successResponseWithDatat and errorResppnse). Why use return res...?

Kaytbode · 2019-09-14T11:09:19Z

src/controllers/notifyControllers.js

+  },
+
+  readAllNotification: async (req, res) => {
+    try {


@ChidiChuks You really put in a lot of efforts into this

Are you supposed to implement this function readAllNotification? because there is a task on the PT that has to do with reading notifications

@ChidiChuks You really put in a lot of efforts into this

Are you supposed to implement this function readAllNotification? because there is a task on the PT that has to do with reading notifications

Oh yes, I had to do this to be able to test the algorithm and see that the notification is working

Kaytbode

@ChidiChuks You have really done a great job with the implementation of this feature, and i understand how stressful it could be spending so much time, on a task.

I left some questions for you while going through the code. Please your response is needed mainly as a form of clarity.

hound · 2019-09-14T20:02:34Z

src/validation/travelValidation.js

+  .isEmpty()
+  .withMessage(message.emptyAccommodation)
+  .isInt()
+  .withMessage(message.isNotInteger)


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:34Z

src/validation/travelValidation.js

+  .not()
+  .isEmpty()
+  .withMessage(message.emptyAccommodation)
+  .isInt()


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:35Z

src/validation/travelValidation.js

+  check('accommodation_id')
+  .not()
+  .isEmpty()
+  .withMessage(message.emptyAccommodation)


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:35Z

src/validation/travelValidation.js

+  .withMessage(message.emptyTravelPurpose),
+  check('accommodation_id')
+  .not()
+  .isEmpty()


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:35Z

src/validation/travelValidation.js

+  .isEmpty()
+  .withMessage(message.emptyTravelPurpose),
+  check('accommodation_id')
+  .not()


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:36Z

src/validation/travelValidation.js

+  check('return_date')
+  .not()
+  .isEmpty()
+  .withMessage(message.emptyReturnDate)


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:36Z

src/validation/travelValidation.js

+  .bail(),
+  check('return_date')
+  .not()
+  .isEmpty()


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:36Z

src/validation/travelValidation.js

+  .withMessage(message.isNotISODate)
+  .bail(),
+  check('return_date')
+  .not()


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:36Z

src/validation/travelValidation.js

+  .withMessage(message.emptyDepartureDate)
+  .isISO8601()
+  .withMessage(message.isNotISODate)
+  .bail(),


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T20:02:37Z

src/validation/travelValidation.js

+  .isEmpty()
+  .withMessage(message.emptyDepartureDate)
+  .isISO8601()
+  .withMessage(message.isNotISODate)


Expected indentation of 4 spaces but found 2 indent

hound · 2019-09-14T22:16:39Z

src/utils/messageUtils.js

+    userEmailNotFound: (email) => `Sorry, there is no user with email ${email} in the database.`,
+    userIdNotFound: (id) => `Sorry, there is no user with id: ${id} in the database.`,
+    unregisteredEmail: (email) => `User with this email (${email}) not found in our database.`,
+    wrongRole: (role) => `Sorry, you are not a/an ${role}.`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:16:39Z

src/utils/messageUtils.js

+    successfullyApproval: (requester) => `You have successfully approved a travel request from ${requester}.`,
+    userEmailNotFound: (email) => `Sorry, there is no user with email ${email} in the database.`,
+    userIdNotFound: (id) => `Sorry, there is no user with id: ${id} in the database.`,
+    unregisteredEmail: (email) => `User with this email (${email}) not found in our database.`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:16:39Z

src/utils/messageUtils.js

+    unauthorizedCommentDelete: "comment can only be deleted by it's author",
+    successfullyApproval: (requester) => `You have successfully approved a travel request from ${requester}.`,
+    userEmailNotFound: (email) => `Sorry, there is no user with email ${email} in the database.`,
+    userIdNotFound: (id) => `Sorry, there is no user with id: ${id} in the database.`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:16:39Z

src/utils/messageUtils.js

+    unauthorizedAccessToTravel: 'Access denied. Accessible only by travel requester or his/her line manager.',
+    unauthorizedCommentDelete: "comment can only be deleted by it's author",
+    successfullyApproval: (requester) => `You have successfully approved a travel request from ${requester}.`,
+    userEmailNotFound: (email) => `Sorry, there is no user with email ${email} in the database.`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:16:40Z

src/utils/messageUtils.js

+    unauthorized: 'Not authorized.',
+    unauthorizedAccessToTravel: 'Access denied. Accessible only by travel requester or his/her line manager.',
+    unauthorizedCommentDelete: "comment can only be deleted by it's author",
+    successfullyApproval: (requester) => `You have successfully approved a travel request from ${requester}.`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:16:41Z

src/utils/messageUtils.js

+    successComment: [
+        'You have successfully commented on a travel request.',
+        'You have successfully retrieved all comments for this travel request.',
+    ],


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:16:41Z

src/utils/messageUtils.js

+    // comment messages
+    successComment: [
+        'You have successfully commented on a travel request.',
+        'You have successfully retrieved all comments for this travel request.',


Expected indentation of 4 spaces but found 8 indent

hound · 2019-09-14T22:16:41Z

src/utils/messageUtils.js

+    returnTripCreated: 'Your return trip request was created successfully.',
+    // comment messages
+    successComment: [
+        'You have successfully commented on a travel request.',


Expected indentation of 4 spaces but found 8 indent

hound · 2019-09-14T22:16:41Z

src/utils/messageUtils.js

+    requestNotPending: 'This Travel Request is not Pending.',
+    returnTripCreated: 'Your return trip request was created successfully.',
+    // comment messages
+    successComment: [


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:16:41Z

src/utils/messageUtils.js

+    nonExistentTravel: 'The travel request does not exist.',
+    requestNotPending: 'This Travel Request is not Pending.',
+    returnTripCreated: 'Your return trip request was created successfully.',
+    // comment messages


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:25Z

src/utils/messageUtils.js

+    getFeedback: (accomm) => `You have successfully retrieved feedback on our accommodation facility with name, ${accomm}.`,
+    accommodationNotFound: 'The accommodation facility does not exist.',
+    invalidAccommodationId: 'The Accommodation ID must be an integer value.',
+    emptyFeedback: 'Feedback field cannot be empty.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:26Z

src/utils/messageUtils.js

+    newFeedback: (accomm) => `You have successfully dropped a feedback on our accomodation facility with name, ${accomm}.`,
+    getFeedback: (accomm) => `You have successfully retrieved feedback on our accommodation facility with name, ${accomm}.`,
+    accommodationNotFound: 'The accommodation facility does not exist.',
+    invalidAccommodationId: 'The Accommodation ID must be an integer value.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:26Z

src/utils/messageUtils.js

+
+    newFeedback: (accomm) => `You have successfully dropped a feedback on our accomodation facility with name, ${accomm}.`,
+    getFeedback: (accomm) => `You have successfully retrieved feedback on our accommodation facility with name, ${accomm}.`,
+    accommodationNotFound: 'The accommodation facility does not exist.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:26Z

src/utils/messageUtils.js

+    wrongRole: (role) => `Sorry, you are not a/an ${role}.`,
+
+    newFeedback: (accomm) => `You have successfully dropped a feedback on our accomodation facility with name, ${accomm}.`,
+    getFeedback: (accomm) => `You have successfully retrieved feedback on our accommodation facility with name, ${accomm}.`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:26Z

src/utils/messageUtils.js

+    unregisteredEmail: (email) => `User with this email (${email}) not found in our database.`,
+    wrongRole: (role) => `Sorry, you are not a/an ${role}.`,
+
+    newFeedback: (accomm) => `You have successfully dropped a feedback on our accomodation facility with name, ${accomm}.`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:27Z

src/utils/messageUtils.js

+    invalidToken: 'Invalid Token, please login.',
+    invalidTravelType: 'Sorry you can only make return trip request here.',
+    invalidTravelId: 'The travel ID must be an integer value.',
+    invalidUserId: 'Sorry you can only create the request with the id of the logged in user.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:27Z

src/utils/messageUtils.js

+    isNotISODate: "Your date must be of ISO8601 standard '2019-01-10'.",
+    invalidToken: 'Invalid Token, please login.',
+    invalidTravelType: 'Sorry you can only make return trip request here.',
+    invalidTravelId: 'The travel ID must be an integer value.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:28Z

src/utils/messageUtils.js

+    isNotInteger: 'You must enter a valid integer type.',
+    isNotISODate: "Your date must be of ISO8601 standard '2019-01-10'.",
+    invalidToken: 'Invalid Token, please login.',
+    invalidTravelType: 'Sorry you can only make return trip request here.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:28Z

src/utils/messageUtils.js

+    incorrectPassword: 'Sorry, the password entered is not correct.',
+    isNotInteger: 'You must enter a valid integer type.',
+    isNotISODate: "Your date must be of ISO8601 standard '2019-01-10'.",
+    invalidToken: 'Invalid Token, please login.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:31:28Z

src/utils/messageUtils.js

+    lineManager: 'Line manager must be present to continue',
+    incorrectPassword: 'Sorry, the password entered is not correct.',
+    isNotInteger: 'You must enter a valid integer type.',
+    isNotISODate: "Your date must be of ISO8601 standard '2019-01-10'.",


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:01Z

src/utils/messageUtils.js

+    notifyUser: 'Your travel request has been successfully created and it is awaiting approval',
+    lineManager: 'Line manager must be present to continue',
+    incorrectPassword: 'Sorry, the password entered is not correct.',
+    isNotInteger: 'You must enter a valid integer type.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:02Z

src/utils/messageUtils.js

+    emptyTravelType: 'Sorry, travel type can not be empty.',
+    notifyUser: 'Your travel request has been successfully created and it is awaiting approval',
+    lineManager: 'Line manager must be present to continue',
+    incorrectPassword: 'Sorry, the password entered is not correct.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:02Z

src/utils/messageUtils.js

+    emptyTravelPurpose: 'You must state your travel purpose',
+    emptyTravelType: 'Sorry, travel type can not be empty.',
+    notifyUser: 'Your travel request has been successfully created and it is awaiting approval',
+    lineManager: 'Line manager must be present to continue',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:02Z

src/utils/messageUtils.js

+    emptyReturnDate: 'You must state your return date',
+    emptyTravelPurpose: 'You must state your travel purpose',
+    emptyTravelType: 'Sorry, travel type can not be empty.',
+    notifyUser: 'Your travel request has been successfully created and it is awaiting approval',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:02Z

src/utils/messageUtils.js

+    emptyOrigin: 'You must state your current city.',
+    emptyReturnDate: 'You must state your return date',
+    emptyTravelPurpose: 'You must state your travel purpose',
+    emptyTravelType: 'Sorry, travel type can not be empty.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:03Z

src/utils/messageUtils.js

+    emptyAccommodation: 'You must select an accommodation.',
+    emptyComment: 'comment cannot be empty.',
+    emptyDepartureDate: 'You must state your departure date',
+    emptyDestination: 'You must state your destination',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:04Z

src/utils/messageUtils.js

+    diffDepartment: 'You are not in the same department as the Travel Requester.',
+    emptyAccommodation: 'You must select an accommodation.',
+    emptyComment: 'comment cannot be empty.',
+    emptyDepartureDate: 'You must state your departure date',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:04Z

src/utils/messageUtils.js

+    deleteComment: 'Comment successfully deleted.',
+    diffDepartment: 'You are not in the same department as the Travel Requester.',
+    emptyAccommodation: 'You must select an accommodation.',
+    emptyComment: 'comment cannot be empty.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:04Z

src/utils/messageUtils.js

+    dateForToday: "Please your departure date must be equal to or greater than today's date.",
+    deleteComment: 'Comment successfully deleted.',
+    diffDepartment: 'You are not in the same department as the Travel Requester.',
+    emptyAccommodation: 'You must select an accommodation.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:38:04Z

src/utils/messageUtils.js

+    dateForFuture: 'Please enter a date greater than the departure date for return date.',
+    dateForToday: "Please your departure date must be equal to or greater than today's date.",
+    deleteComment: 'Comment successfully deleted.',
+    diffDepartment: 'You are not in the same department as the Travel Requester.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:24Z

src/utils/messageUtils.js

+    commentNotFound: 'The comment does not exist.',
+    dateForFuture: 'Please enter a date greater than the departure date for return date.',
+    dateForToday: "Please your departure date must be equal to or greater than today's date.",
+    deleteComment: 'Comment successfully deleted.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:24Z

src/utils/messageUtils.js

+    noDigitInPassword: 'Password must contain at least one digit.',
+    commentNotFound: 'The comment does not exist.',
+    dateForFuture: 'Please enter a date greater than the departure date for return date.',
+    dateForToday: "Please your departure date must be equal to or greater than today's date.",


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:24Z

src/utils/messageUtils.js

+    shortPassword: 'The length of the password must be 8 and above.',
+    noDigitInPassword: 'Password must contain at least one digit.',
+    commentNotFound: 'The comment does not exist.',
+    dateForFuture: 'Please enter a date greater than the departure date for return date.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:24Z

src/utils/messageUtils.js

+    usedEmail: (email) => `User with this email (${email}) already exist.`,
+    shortPassword: 'The length of the password must be 8 and above.',
+    noDigitInPassword: 'Password must contain at least one digit.',
+    commentNotFound: 'The comment does not exist.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:24Z

src/utils/messageUtils.js

+    invalidEmail: 'Please, enter a valid email address.',
+    usedEmail: (email) => `User with this email (${email}) already exist.`,
+    shortPassword: 'The length of the password must be 8 and above.',
+    noDigitInPassword: 'Password must contain at least one digit.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:25Z

src/utils/messageUtils.js

+    managerApproval: (pendingReq) => `You have ${pendingReq} requests requiring your approval`,
+    managerNotFound: "Manager's detail missing",
+    requestNotOpen: 'Your request is no longer open for editing.',
+    requestUpdated: 'Your request has been successfully updated',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:25Z

src/utils/messageUtils.js

+    oneWayTripCreated: 'Your request has been successfully created',
+    managerApproval: (pendingReq) => `You have ${pendingReq} requests requiring your approval`,
+    managerNotFound: "Manager's detail missing",
+    requestNotOpen: 'Your request is no longer open for editing.',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:26Z

src/utils/messageUtils.js

+    // Travel requests messages
+    oneWayTripCreated: 'Your request has been successfully created',
+    managerApproval: (pendingReq) => `You have ${pendingReq} requests requiring your approval`,
+    managerNotFound: "Manager's detail missing",


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:26Z

src/utils/messageUtils.js

+    signupSuccess: (email) => `You have successfully registered with this email, ${email}.`,
+    // Travel requests messages
+    oneWayTripCreated: 'Your request has been successfully created',
+    managerApproval: (pendingReq) => `You have ${pendingReq} requests requiring your approval`,


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T22:55:26Z

src/utils/messageUtils.js

+    welcome: 'Welcome to Archangel Barefoot Nomad Web App API.',
+    signupSuccess: (email) => `You have successfully registered with this email, ${email}.`,
+    // Travel requests messages
+    oneWayTripCreated: 'Your request has been successfully created',


Expected indentation of 2 spaces but found 4 indent

hound · 2019-09-14T23:05:05Z

src/utils/messageUtils.js

@@ -37,6 +38,8 @@ export default {
  emptyReturnDate: 'You must state your return date',
  emptyTravelPurpose: 'You must state your travel purpose',
  emptyTravelType: 'Sorry, travel type can not be empty.',
+notifyUser: 'Your travel request has been successfully created and it is awaiting approval',


Expected indentation of 2 spaces but found 0 indent

inputting pusher trigger

hound · 2019-09-17T17:08:25Z

src/controllers/travelControllers.js

+    });
+    const notificationMessage = notificationObj.dataValues;
+
+    console.log(notificationMessage);


Unexpected console statement no-console

hound · 2019-09-17T17:08:25Z

src/controllers/travelControllers.js

+      )
+    });
+    const notificationMessage = notificationObj.dataValues;
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-09-17T17:08:25Z

src/controllers/travelControllers.js

+      travel_id: data.dataValues.id,
+      message: message.notificationReturnMessage(
+        first_name, data.dataValues.origin
+      )


Unexpected newline before ')' function-paren-newline

hound · 2019-09-17T17:08:25Z

src/controllers/travelControllers.js

+      recipient_id: dept.manager_user_id,
+      travel_id: data.dataValues.id,
+      message: message.notificationReturnMessage(
+        first_name, data.dataValues.origin


'data' is not defined no-undef

hound · 2019-09-17T17:08:26Z

src/controllers/travelControllers.js

+    const notificationObj = await createNotification({
+      recipient_id: dept.manager_user_id,
+      travel_id: data.dataValues.id,
+      message: message.notificationReturnMessage(


Unexpected newline after '(' function-paren-newline

hound · 2019-09-17T17:08:26Z

src/controllers/travelControllers.js

+
+    delete notificationMessage.recipient_id;
+    notificationMessage.title = 'New Travel Request.';
+    console.log(`new-travel-${dept.manager_user_id}`)


Missing semicolon semi
Unexpected console statement no-console

hound · 2019-09-17T17:08:26Z

src/controllers/travelControllers.js

+    });
+    const notificationMessage = notificationObj.dataValues;
+
+    console.log(notificationMessage);


Unexpected console statement no-console

hound · 2019-09-17T17:08:26Z

src/controllers/travelControllers.js

+      travel_id: data.dataValues.id,
+      message: message.notificationTravelMessage(
+        first_name, data.dataValues.origin
+      )


Unexpected newline before ')' function-paren-newline

hound · 2019-09-17T17:08:27Z

src/controllers/travelControllers.js

+    const notificationObj = await createNotification({
+      recipient_id: dept.manager_user_id,
+      travel_id: data.dataValues.id,
+      message: message.notificationTravelMessage(


Unexpected newline after '(' function-paren-newline

hound · 2019-09-17T17:08:27Z

src/controllers/travelControllers.js

@@ -31,6 +33,29 @@ const createOneWayTrip = async(req, res) => {
      dept_id,
    });

+    const dept = await getADepartment(dept_id);
+


Trailing spaces not allowed no-trailing-spaces

ChidiChuks added question Further information is requested help wanted Extra attention is needed labels Sep 3, 2019

ChidiChuks changed the title ~~#167730641 Notifying New Travel Request~~ #167730641 Notifying New Travel Request [WIP} Sep 3, 2019

ChidiChuks changed the title ~~#167730641 Notifying New Travel Request [WIP}~~ #167730641 Notifying New Travel Request [WIP] Sep 3, 2019

ChidiChuks changed the title ~~#167730641 Notifying New Travel Request [WIP]~~ Notifying New Travel Request [WIP] Sep 3, 2019

ChidiChuks changed the title ~~Notifying New Travel Request [WIP]~~ [WIP] Notifying New Travel Request Sep 3, 2019

hound bot reviewed Sep 4, 2019

View reviewed changes

ChidiChuks added the work-in-progress label Sep 4, 2019

hound bot reviewed Sep 4, 2019

View reviewed changes

hound bot reviewed Sep 5, 2019

View reviewed changes

ChidiChuks removed help wanted Extra attention is needed question Further information is requested labels Sep 6, 2019

hound bot reviewed Sep 8, 2019

View reviewed changes

hound bot reviewed Sep 9, 2019

View reviewed changes

hound bot reviewed Sep 10, 2019

View reviewed changes

hound bot reviewed Sep 11, 2019

View reviewed changes

ChidiChuks added 8 commits September 13, 2019 13:37

updated travis and test

50645bb

feature(notify-request): notify manager of travel request

5d29574

- Create a table - Install dependencies and [Start #167730641]

pop-up of stashed commits

a398362

declaring server as a function in the entry point

e16b72e

setting up the project

7b1af3a

updating the controller and test files with line-spacing

ce3ea15

updating the .env file to hold values for sendGrid

5e8e023

created service and routes files

1e22bad

ChidiChuks requested a review from chuksjoe September 13, 2019 17:05

Merge branch 'develop' into ft-notify-new-travel-167730641

b7a3902

hound bot reviewed Sep 13, 2019

View reviewed changes

ChidiChuks added 2 commits September 13, 2019 18:48

hound bot reviewed Sep 13, 2019

View reviewed changes

chuksjoe reviewed Sep 13, 2019

View reviewed changes

hound bot reviewed Sep 13, 2019

View reviewed changes

danoseun reviewed Sep 13, 2019

View reviewed changes

hound bot reviewed Sep 13, 2019

View reviewed changes

chuksjoe requested changes Sep 14, 2019

View reviewed changes

Kaytbode reviewed Sep 14, 2019

View reviewed changes

Kaytbode requested changes Sep 14, 2019

View reviewed changes

hound bot reviewed Sep 14, 2019

View reviewed changes

resolved conflicts

07d0a3d

ChidiChuks force-pushed the ft-notify-new-travel-167730641 branch from 2d05eaa to 07d0a3d Compare September 14, 2019 22:16

hound bot reviewed Sep 14, 2019

View reviewed changes

resolved conflicts

eeda180

hound bot reviewed Sep 14, 2019

View reviewed changes

ChidiChuks force-pushed the ft-notify-new-travel-167730641 branch from 5c6dd8e to eeda180 Compare September 14, 2019 22:55

hound bot reviewed Sep 14, 2019

View reviewed changes

danoseun self-requested a review September 17, 2019 10:40

resolving merge conflicts

ae666f1

inputting pusher trigger

ChidiChuks force-pushed the ft-notify-new-travel-167730641 branch from 0396070 to ae666f1 Compare September 17, 2019 17:08

hound bot reviewed Sep 17, 2019

View reviewed changes

		@@ -0,0 +1,23 @@
		module.exports = {
		up: (queryInterface, Sequelize) => {

		@@ -0,0 +1,13 @@
		module.exports = (sequelize, DataTypes) => {

		@@ -0,0 +1,17 @@
		module.exports = (sequelize, DataTypes) => {

		@@ -0,0 +1,5 @@
		import { io } from '..';

		export const eventEmitter = (eventName, data) => {


		const { getProfile } = profileController;

		const router = express.Router();


		const travelObj = { user_id:userId, origin, destination, departure_date, travel_purpose };

		const travelObj = { user_id: userId, origin, destination, departure_date, travel_purpose };

		@@ -1,3 +1,5 @@
		import autoBind from 'auto-bind';
		import notifyServices from '../services/websocket'

		@@ -0,0 +1,23 @@
		module.exports = {
		up: (queryInterface) => queryInterface.bulkInsert(


		const data = await oneWayTripService(travelObj);

		const emailVerify = await sendVerificationEmail(email,

#167730641 Notifying New Travel Request #20

Are you sure you want to change the base?

#167730641 Notifying New Travel Request #20

Conversation

ChidiChuks commented Sep 3, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

chuksjoe commented Sep 3, 2019

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 4, 2019

Choose a reason for hiding this comment

ChidiChuks commented Sep 4, 2019

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 4, 2019

Choose a reason for hiding this comment

hound bot Sep 5, 2019

Choose a reason for hiding this comment

hound bot Sep 5, 2019

Choose a reason for hiding this comment

hound bot Sep 8, 2019

Choose a reason for hiding this comment

hound bot Sep 8, 2019

Choose a reason for hiding this comment

hound bot Sep 8, 2019

Choose a reason for hiding this comment

Kaytbode Sep 14, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

hound bot Sep 9, 2019

Choose a reason for hiding this comment

ChidiChuks commented Sep 3, 2019 •

edited

Loading